Fix Windows extension install from downloads.php.net zip (eg apcu/apcu)#511
Closed
GhostPirateBob wants to merge 6 commits intophp:1.4.xfrom
Closed
Fix Windows extension install from downloads.php.net zip (eg apcu/apcu)#511GhostPirateBob wants to merge 6 commits intophp:1.4.xfrom
GhostPirateBob wants to merge 6 commits intophp:1.4.xfrom
Conversation
- Generate asset name variants for "x64" arch (not just "x86_64") and versions without "v" prefix - Add Architecture::windowsName() for conventional Windows arch labels - Fall back to downloads.php.net/~windows/pecl/releases/ when GitHub release has no matching Windows binary - Support simple DLL naming (e.g. "php_apcu.dll") used in downloads.php.net zips
GhostPirateBob
force-pushed
the
1.4.x
branch
2 times, most recently
from
cbc0e8e to
b608c0d
Compare
Zlib 1.3.2 changed its output names. The library files are now named z.lib, z.dll, and zs.lib instead of the old zlib.lib, zlib.dll, and zlibstatic.lib that SPC expects. SPC's zlib.php builder tries to: 1. Copy zlibstatic.lib — doesn't exist (it's zs.lib now) 2. Delete zlib.dll — doesn't exist (it's z.dll now) 3. Delete zlib.lib — doesn't exist (it's z.lib now)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
closing to split this into two issues/PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
G'day folks!
This is my first contribution to this repo, so please let me know if there’s a preferred way to structure things.
I had a weird issue on Windows with the latest nightly and 1.3.8 stable where
pie install apcu/apcudidn't work, even though there was a valid zip file and dll for my version.Turns out it was just because of inconsistent file naming between GitHub releases, php.net releases and the dll name inside the zip file. So I did my best to try and write (somewhat Windows specific) fallbacks. Worked for me, I've not tested it super thoroughly on MacOS and Linux, but my Windows code should be fairly well scoped to that OS.
Cheers!
gpb
✌(◕‿-)✌
Summary of changes
Output Logs
Screenshots (both issues and after fix)