-
Notifications
You must be signed in to change notification settings - Fork 18
Consent Manager ext integration #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iMattPro
wants to merge
12
commits into
master
Choose a base branch
from
consent-manager
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9591c3c
Support consent manager
iMattPro 8945880
Add a toggle so ads can disable consent management on an ad
iMattPro 0a6c0a7
Remove functional consent manager test since it depends on the extension
iMattPro e967caf
Update tests
iMattPro 8861cfe
Ad code analyser will flag ads that could require consent
iMattPro ac94cf0
Test for iframes
iMattPro 0c2e0bf
Fix language files
iMattPro 54ff0a5
Merge branch 'master' into consent-manager
iMattPro cf907fd
Let Google Ad codes be handled by Google Consent Mode
iMattPro 8f2dd12
Update tests
iMattPro 4e9995e
Remove code duplication
iMattPro d89f4c8
Merge branch 'master' into consent-manager
iMattPro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| <?php | ||
| /** | ||
| * | ||
| * Advertisement management. An extension for the phpBB Forum Software package. | ||
| * | ||
| * @copyright (c) 2026 phpBB Limited <https://www.phpbb.com> | ||
| * @license GNU General Public License, version 2 (GPL-2.0) | ||
| * | ||
| */ | ||
|
|
||
| namespace phpbb\ads\analyser\test; | ||
|
|
||
| class iframe implements test_interface | ||
| { | ||
| /** | ||
| * {@inheritDoc} | ||
| * | ||
| * Iframes test. | ||
| * This test looks for iframe tags with src attributes. Such scripts could introduce | ||
| * external trackers and data collectors that could require user consent. | ||
| */ | ||
| public function run($ad_code, array $context = array()) | ||
| { | ||
| if (preg_match('/<iframe(?>(?!>).)*?(?<=\s|")src\s*=\s*".*?>/is', $ad_code)) | ||
| { | ||
| return array( | ||
| 'severity' => 'notice', | ||
| 'message' => 'IFRAME_USAGE', | ||
| ); | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.