Skip to content

Merge 3.3.x into master #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iMattPro merged 3 commits into from
May 17, 2025
Merged

Merge 3.3.x into master #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7bb066
Cache composer and NPM dependencies
iMattPro May 17, 2025
312e2ae
Quick Bertie bear image update too
iMattPro May 17, 2025
b31ffe4
Merge pull request #41 from iMattPro/cache-deps
iMattPro May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 88 additions & 12 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,18 +255,37 @@ jobs:
run: .github/setup-database.sh $DB $MYISAM
working-directory: ./phpBB3

- name: Install NPM dependencies
- name: Set up Node.js
if: ${{ inputs.RUN_NPM_INSTALL == '1' }}
uses: actions/setup-node@v4
with:
node-version: 20
node-version: 20

- name: Cache NPM dependencies
if: ${{ inputs.RUN_NPM_INSTALL == '1' }}
uses: actions/cache@v4
with:
path: ./phpBB3/phpBB/ext/${{ env.EXTNAME }}/node_modules
key: ${{ runner.os }}-node-${{ hashFiles('phpBB3/phpBB/ext/${{ env.EXTNAME }}/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-

- name: Run npm ci
if: ${{ inputs.RUN_NPM_INSTALL == '1' }}
run: npm ci
working-directory: ./phpBB3/phpBB/ext/${{ env.EXTNAME }}

- name: Install composer dependencies
- name: Cache Composer dependencies
if: ${{ inputs.RUN_COMPOSER_INSTALL == '1' }}
uses: actions/cache@v4
with:
path: ./phpBB3/phpBB/ext/${{ env.EXTNAME }}/vendor
key: ${{ runner.os }}-composer-${{ matrix.php }}-${{ hashFiles('phpBB3/phpBB/ext/${{ env.EXTNAME }}/composer.lock') }}
restore-keys: |
${{ runner.os }}-composer-${{ matrix.php }}-
${{ runner.os }}-composer-

- name: Install Composer dependencies
if: ${{ inputs.RUN_COMPOSER_INSTALL == '1' }}
run: composer install
working-directory: ./phpBB3/phpBB/ext/${{ env.EXTNAME }}
Expand Down Expand Up @@ -404,18 +423,37 @@ jobs:
run: .github/setup-database.sh $DB $MYISAM
working-directory: ./phpBB3

- name: Install NPM dependencies
- name: Set up Node.js
if: ${{ inputs.RUN_NPM_INSTALL == '1' }}
uses: actions/setup-node@v4
with:
node-version: 20
node-version: 20

- name: Cache NPM dependencies
if: ${{ inputs.RUN_NPM_INSTALL == '1' }}
uses: actions/cache@v4
with:
path: ./phpBB3/phpBB/ext/${{ env.EXTNAME }}/node_modules
key: ${{ runner.os }}-node-${{ hashFiles('phpBB3/phpBB/ext/${{ env.EXTNAME }}/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-

- name: Run npm ci
if: ${{ inputs.RUN_NPM_INSTALL == '1' }}
run: npm ci
working-directory: ./phpBB3/phpBB/ext/${{ env.EXTNAME }}

- name: Install composer dependencies
- name: Cache Composer dependencies
if: ${{ inputs.RUN_COMPOSER_INSTALL == '1' }}
uses: actions/cache@v4
with:
path: ./phpBB3/phpBB/ext/${{ env.EXTNAME }}/vendor
key: ${{ runner.os }}-composer-${{ matrix.php }}-${{ hashFiles('phpBB3/phpBB/ext/${{ env.EXTNAME }}/composer.lock') }}
restore-keys: |
${{ runner.os }}-composer-${{ matrix.php }}-
${{ runner.os }}-composer-

- name: Install Composer dependencies
if: ${{ inputs.RUN_COMPOSER_INSTALL == '1' }}
run: composer install
working-directory: ./phpBB3/phpBB/ext/${{ env.EXTNAME }}
Expand Down Expand Up @@ -525,18 +563,37 @@ jobs:
run: .github/setup-database.sh $DB $MYISAM
working-directory: ./phpBB3

- name: Install NPM dependencies
- name: Set up Node.js
if: ${{ inputs.RUN_NPM_INSTALL == '1' }}
uses: actions/setup-node@v4
with:
node-version: 20
node-version: 20

- name: Cache NPM dependencies
if: ${{ inputs.RUN_NPM_INSTALL == '1' }}
uses: actions/cache@v4
with:
path: ./phpBB3/phpBB/ext/${{ env.EXTNAME }}/node_modules
key: ${{ runner.os }}-node-${{ hashFiles('phpBB3/phpBB/ext/${{ env.EXTNAME }}/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-

- name: Run npm ci
if: ${{ inputs.RUN_NPM_INSTALL == '1' }}
run: npm ci
working-directory: ./phpBB3/phpBB/ext/${{ env.EXTNAME }}

- name: Install composer dependencies
- name: Cache Composer dependencies
if: ${{ inputs.RUN_COMPOSER_INSTALL == '1' }}
uses: actions/cache@v4
with:
path: ./phpBB3/phpBB/ext/${{ env.EXTNAME }}/vendor
key: ${{ runner.os }}-composer-${{ matrix.php }}-${{ hashFiles('phpBB3/phpBB/ext/${{ env.EXTNAME }}/composer.lock') }}
restore-keys: |
${{ runner.os }}-composer-${{ matrix.php }}-
${{ runner.os }}-composer-

- name: Install Composer dependencies
if: ${{ inputs.RUN_COMPOSER_INSTALL == '1' }}
run: composer install
working-directory: ./phpBB3/phpBB/ext/${{ env.EXTNAME }}
Expand Down Expand Up @@ -657,18 +714,37 @@ jobs:
Set-MpPreference -ExclusionPath "${env:PGDATA}" # Exclude PGDATA directory from Windows Defender
Set-MpPreference -DisableRealtimeMonitoring $true

- name: Install NPM dependencies
- name: Set up Node.js
if: ${{ inputs.RUN_NPM_INSTALL == '1' }}
uses: actions/setup-node@v4
with:
node-version: 20
node-version: 20

- name: Cache NPM dependencies
if: ${{ inputs.RUN_NPM_INSTALL == '1' }}
uses: actions/cache@v4
with:
path: ./phpBB3/phpBB/ext/${{ env.EXTNAME }}/node_modules
key: ${{ runner.os }}-node-${{ hashFiles('phpBB3/phpBB/ext/${{ env.EXTNAME }}/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-

- name: Run npm ci
if: ${{ inputs.RUN_NPM_INSTALL == '1' }}
run: npm ci
working-directory: .\phpBB3\phpBB\ext\${{ env.EXTNAME }}

- name: Install composer dependencies
- name: Cache Composer dependencies
if: ${{ inputs.RUN_COMPOSER_INSTALL == '1' }}
uses: actions/cache@v4
with:
path: ./phpBB3/phpBB/ext/${{ env.EXTNAME }}/vendor
key: ${{ runner.os }}-composer-${{ matrix.php }}-${{ hashFiles('phpBB3/phpBB/ext/${{ env.EXTNAME }}/composer.lock') }}
restore-keys: |
${{ runner.os }}-composer-${{ matrix.php }}-
${{ runner.os }}-composer-

- name: Install Composer dependencies
if: ${{ inputs.RUN_COMPOSER_INSTALL == '1' }}
run: composer install
working-directory: .\phpBB3\phpBB\ext\${{ env.EXTNAME }}
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# phpBB Extension Test Framework

<img align="left" src="detective-bertie.png" alt="Detective Bertie running diagnostics" height="200" width="200">
<img align="left" src="https://raw.githubusercontent.com/phpbb/website-assets/master/images/images/extensions/detective-bertie.png" alt="Detective Bertie running diagnostics" height="200" width="200">

This repository provides a reusable GitHub Actions workflow for phpBB extension developers.

Expand Down
Binary file removed detective-bertie.png
View file
Open in desktop
Binary file not shown.