Fix: Store parent of most deeply nested element during expansion#516
Merged
Fix: Store parent of most deeply nested element during expansion#516
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 11 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
Member
Author
|
I've been working on the DHPL project again this morning and loaded this branch using composer. It immediately fixed the issue, apart from where It's all resolved now. I'll continue to test and then merge later if nothing else comes up. |
…list-bug # Conflicts: # src/DocumentBinder.php # test/phpunit/DocumentBinderTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the parent of the most deeply nested element was not correctly stored during expansion. It ensures proper hierarchy tracking by storing a properly-normalised version path to the component's original location in the tree.