Process unrolled foreach iteration body in original context#5559
Merged
ondrejmirtes merged 2 commits into2.1.xfrom Apr 28, 2026
Merged
Process unrolled foreach iteration body in original context#5559ondrejmirtes merged 2 commits into2.1.xfrom
ondrejmirtes merged 2 commits into2.1.xfrom
Conversation
…sted loops stabilize Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Closes phpstan/phpstan#9332 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$context->enterDeep(), which suppressesLOOP_SCOPE_ITERATIONSstabilization in nested loops. Because unrolling visits each element exactly once (no outer iteration to converge accumulators), nested loops inside the body produced single-element constant arrays instead of stabilized list/non-empty-list types.$contexttoprocessStmtNodesInternal, so nested loops inside an unrolled iteration's body can stabilize on their own (the non-unrolled path still usesenterDeepbecause the outer 3-iteration loop is what makes accumulators converge there).bug-14543.phpandbug-9332.phpfor the reported cases.bug-14489.phpexpectation to the more precisearray{array{1}, array{4}}since the inner foreach over a fully-known constant array now also unrolls and produces precise sequential types (verified to match runtime output viaphp -r).Test plan
vendor/bin/phpunit tests/PHPStan/Analyser/NodeScopeResolverTest.php— 1557 tests, 0 failuresCloses phpstan/phpstan#9332
Closes phpstan/phpstan#14543
🤖 Generated with Claude Code