Don't report "no value type specified in iterable type array&callable"

[staabm]

refs phpstan/phpstan#14549

[phpstan-bot]

You've opened the pull request against the latest branch 2.2.x. PHPStan 2.2 is not going to be released for months. If your code is relevant on 2.1.x and you want it to be released sooner, please rebase your pull request and change its target to 2.1.x.

[ondrejmirtes]

Also we could improve IntersectionType getIterableKeyType and ValueType if the type is array and callable.

[VincentLanglet]

Also we could improve IntersectionType getIterableKeyType and ValueType if the type is array and callable.

That's not enough, because it won't report
https://phpstan.org/r/c90e4fe4-2ce7-4be3-8529-ae517dd5c445

[VincentLanglet]

closes phpstan/phpstan#14549

I opened the issue about the fact it doesn't report an error on the line

$this->call($task);

So the current state of this PR doesn't solve it @staabm

[ondrejmirtes]

I'd be interested why the line isn't reported there, seems like deficiency of ConstantArrayType::accepts().

[staabm]

That's not enough, because it won't report

@VincentLanglet running https://phpstan.org/r/c90e4fe4-2ce7-4be3-8529-ae517dd5c445 locally I get a error on line 13 (even on 2.1.x)

➜  phpstan-src git:(2.1.x) ✗ php bin/phpstan analyze foo.php --debug 
Note: Using configuration file /Users/staabm/workspace/phpstan-src/phpstan.neon.dist.
/Users/staabm/workspace/phpstan-src/foo.php
 ------ -------------------------------------------------------------------------------------------------------------------------- 
  Line   foo.php                                                                                                                   
 ------ -------------------------------------------------------------------------------------------------------------------------- 
  6      Class MondayMorning must be abstract or final.                                                                            
         🪪  phpstan.finalClass                                                                                                    
         at foo.php:6                                                                                                              
  8      Method MondayMorning::foo() has parameter $task with no value type specified in iterable type array.                      
         🪪  missingType.iterableValue                                                                                             
         💡  See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type                                
         at foo.php:8                                                                                                              
  11     Dumped type: array&callable(): mixed                                                                                      
         🪪  phpstan.dumpType (non-ignorable)                                                                                      
         at foo.php:11                                                                                                             
  13     Parameter #1 $task of method MondayMorning::call() expects array{string, string, string}, array&callable(): mixed given.  
         🪪  argument.type                                                                                                         
         at foo.php:13                                                                                                             
 ------ -------------------------------------------------------------------------------------------------------------------------- 

[staabm]

ok its weird. the error is visible on level 7,8,9 - but not on level 10

https://phpstan.org/r/ad329e91-8e3f-49b4-a30f-d4b3f562d6f6

[staabm]

do empty-callable strings exist? or can we make this non-empty?