Some metadata fixes for SPL classes#5574
Merged
staabm merged 1 commit intophpstan:2.1.xfrom May 1, 2026
Merged
Conversation
Collaborator
|
You've opened the pull request against the latest branch 2.2.x. PHPStan 2.2 is not going to be released for months. If your code is relevant on 2.1.x and you want it to be released sooner, please rebase your pull request and change its target to 2.1.x. |
| 'SplFileObject::fseek' => ['hasSideEffects' => true], | ||
| 'SplFileObject::ftruncate' => ['hasSideEffects' => true], | ||
| 'SplFileObject::fwrite' => ['hasSideEffects' => true], | ||
| 'SplFixedArray::extract' => ['hasSideEffects' => true], |
Contributor
There was a problem hiding this comment.
This file is generated automatically when running bin/generate-function-metadata.php
You should modify bin/functionMetadata_original.php instead
bitwise-operators
force-pushed
the
fix-splhead-metadata
branch
2 times, most recently
from
9b6bd9c to
101b456
Compare
Contributor
Author
|
Fixed. Also changed target to 2.1.x |
VincentLanglet
approved these changes
Apr 30, 2026
| 'ReflectionMethod::isProtected' => ['hasSideEffects' => false], | ||
| 'ReflectionMethod::isPublic' => ['hasSideEffects' => false], | ||
| 'ReflectionMethod::isStatic' => ['hasSideEffects' => false], | ||
| 'ReflectionMethod::setAccessible' => ['hasSideEffects' => false], |
Contributor
There was a problem hiding this comment.
NB: I think this is a consequences of JetBrains/phpstorm-stubs#1876
I didn't regenerated the metadata when I bumped the phpstorm stubs.
Contributor
Author
There was a problem hiding this comment.
Yeah, I suspected something like that.
staabm
force-pushed
the
fix-splhead-metadata
branch
from
101b456 to
48e7e24
Compare
Contributor
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes:
SplHeapwas misnamed asSplHeadSplFixedArray::extract()method replaced with missingSplFixedArray::setSize()method