Inherit PHPDoc type from parent/interface properties for promoted constructor properties

[phpstan-bot]

Summary

When an interface or parent class declares a property with a PHPDoc type (e.g. /** @var array<string> */), regular (non-promoted) properties in implementing/extending classes correctly inherit that PHPDoc type. However, promoted constructor properties did not inherit the type, causing false positive covariance errors like "PHPDoc type array of property C::$test is not covariant with PHPDoc type array of overridden property A::$test".

This PR makes promoted properties inherit PHPDoc types from parent/interface properties when they don't have their own explicit type annotation.

Changes

• src/Reflection/Php/PhpClassReflectionExtension.php: Added a fallback in createProperty() that calls PhpDocInheritanceResolver::resolvePhpDocForProperty() for promoted properties when no type is found from local @var or constructor @param tags. This mirrors what already happens for regular properties.

Root cause

In PhpClassReflectionExtension::createProperty(), the PHPDoc resolution logic had two branches:

• Regular properties ($constructorName === null): Called resolvePhpDocForProperty() which merges the current property's PHPDoc with parent/interface PHPDoc
• Promoted properties ($constructorName !== null): Only processed local @var tags and constructor @param tags, never calling resolvePhpDocForProperty()

The fix adds a third fallback after the existing @var and @param checks: if $phpDocType is still null for a promoted property, call resolvePhpDocForProperty() to inherit from the parent/interface.

The priority order is preserved correctly:

1. Local @var on the promoted property (most explicit)
2. Constructor @param for the parameter
3. Inherited from parent/interface property (implicit fallback)

Analogous cases probed

All of these were tested and confirmed working:

• Interface with property hooks → promoted property in implementing class (original bug)
• Parent class → promoted property in child class
• Abstract class → promoted property in concrete class
• Multi-level inheritance (grandparent → parent → promoted child)
• Generic interfaces with template types (e.g. Container<string>)
• Constructor @param correctly overrides inherited type
• Explicit @var on promoted property correctly overrides inherited type

Test

• NSRT test (tests/PHPStan/Analyser/nsrt/bug-14564.php): Verifies inferred types for promoted properties across all analogous cases — interface, parent class, multi-level inheritance, generics, @param override, and @var override.
• Rule test (tests/PHPStan/Rules/Properties/OverridingPropertyRuleTest.php::testBug14564): Verifies no false positive covariance errors from OverridingPropertyRule for promoted properties inheriting PHPDoc types from interfaces and parent classes.

Fixes phpstan/phpstan#14564

[VincentLanglet]

Merge the nsrt and RuleTest fixture file into a single one

[phpstan-bot]

Done. Merged the two test fixture files into a single tests/PHPStan/Analyser/nsrt/bug-14564.php that serves both the NSRT type-inference tests and the OverridingPropertyRuleTest. The separate tests/PHPStan/Rules/Properties/data/bug-14564.php was deleted, and the rule test now points to the shared NSRT file. Both tests pass and make phpstan reports no errors.

[VincentLanglet]

We don't benefit of all the resolution

$isInternal = $resolvedPhpDoc->isInternal();
			$isReadOnlyByPhpDoc = $isReadOnlyByPhpDoc || $resolvedPhpDoc->isReadOnly();
			$isFinal = $isFinal || $resolvedPhpDoc->isFinal();
			$isAllowedPrivateMutation = $resolvedPhpDoc->isAllowedPrivateMutation();

We might just do $resolvedPhpDoc = $this->phpDocInheritanceResolver->resolvePhpDocForProperty before the if ($resolvedPhpDoc !== null) { condition.

Also, we'll need a test with a class Bar extending Foo where Foo has a private property $foo and Bar has a public property $foo to ensure the definition does not conflict now we resolve by inheritance

[phpstan-bot]

Done. Here's what I changed to address VincentLanglet's review:

1. Moved resolvePhpDocForProperty before the metadata block: Instead of a separate inheritance block that only extracted $phpDocType, the call now happens right before if ($resolvedPhpDoc !== null), so promoted properties also inherit isInternal, isReadOnlyByPhpDoc, isFinal, and isAllowedPrivateMutation from parent/interface properties.

2. Adjusted @param override logic: Changed the condition from if ($phpDocType === null) to if ($constructorName !== null && ($phpDocType === null || $docComment === null)) — this ensures @param can override inherited types (when there's no local @var) but still respects an explicit @var annotation on the promoted property.

3. Added private property non-conflict test: New test case with FooWithPrivate (private $items) and BarWithPromoted (public promoted $items) verifying that the child's property doesn't incorrectly inherit from the parent's private property (the existing resolvePropertyPhpDocFromParentClass already returns null for private properties).