Added regression test#5585
Merged
staabm merged 1 commit intophpstan:2.1.xfrom May 3, 2026
Merged
Conversation
VincentLanglet
approved these changes
May 3, 2026
| $this->checkUnionTypes = true; | ||
| $this->analyse([__DIR__ . '/../../Analyser/nsrt/bug-9004.php'], [ | ||
| [ | ||
| 'Cannot assign new offset to list<int>|string.', |
Contributor
There was a problem hiding this comment.
On second reading, This error should not be reported thought
I feel like the issue might not be solved since we just trade an error for another @staabm.
Contributor
Author
There was a problem hiding this comment.
reading ondrejs comment, I got the impression it is a expected error
Contributor
There was a problem hiding this comment.
I understand the opposite, since he say "it shouldn't report: "Cannot assign new offset to array<int, int>|string.""
Contributor
There was a problem hiding this comment.
I'll open a dedicated issue to run the bot
Contributor
Author
There was a problem hiding this comment.
reading it again - you are right
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#9004