Narrow DateInterval->days after DateTimeInterface->diff()#5588
Merged
staabm merged 4 commits intophpstan:2.1.xfrom May 3, 2026
Merged
Narrow DateInterval->days after DateTimeInterface->diff()#5588staabm merged 4 commits intophpstan:2.1.xfrom
DateInterval->days after DateTimeInterface->diff()#5588staabm merged 4 commits intophpstan:2.1.xfrom
Conversation
Contributor
Author
|
//cc @stof |
Contributor
VincentLanglet
left a comment
VincentLanglet
left a comment
There was a problem hiding this comment.
The issue phpstan/phpstan#1452 is related.
I feel like we could update DateIntervalFormatDynamicReturnTypeExtension to conditionnally use the extra check #4442 (or not) based on the fact days is an int.
Contributor
Author
I am not sure I can follow. but it seems you have a concrete idea how/what to solve here. |
VincentLanglet
approved these changes
May 3, 2026
Contributor
VincentLanglet
left a comment
VincentLanglet
left a comment
There was a problem hiding this comment.
I'll do in the next PR then
Contributor
Author
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#14428