Skip to content

Test: revert PR #4829 to verify phpbench catches the regression#5597

Closed
ondrejmirtes wants to merge 9 commits into2.1.xfrom
test-phpbench
Closed

Test: revert PR #4829 to verify phpbench catches the regression#5597
ondrejmirtes wants to merge 9 commits into2.1.xfrom
test-phpbench

Conversation

@ondrejmirtes
Copy link
Copy Markdown
Member

@ondrejmirtes ondrejmirtes commented May 4, 2026

Do not merge. This PR is a deliberate experiment to verify that the phpbench baseline added in 196eba6 (with tests/bench/data/phpdoc-inheritance-speedup.php from d34f7cc) actually detects a regression in PhpDocInheritanceResolver performance.

Summary

Reverts the PhpDocInheritanceResolver rework from #4829 plus the commits that depend on its API or tests, so the slow ancestor-walking PHPDoc resolution comes back. With those reverts in place, CI should run phpbench against the bench file and the assertion in RegressionBench should fail (or at least flag a large regression versus baseline).

Local hyperfine numbers on tests/bench/data/phpdoc-inheritance-speedup.php (10-level chain × 3 interfaces/level × 10 methods, all overridden with PHPDocs):

Reverted commits (newest first)

Test plan

  • All 12027 unit tests pass on this branch (make tests, 1m36s)
  • bin/phpstan analyse -l 8 tests/bench/data/phpdoc-inheritance-speedup.php reproduces the slow path locally (~110s vs ~20s on 2.1.x)
  • CI phpbench step flags a regression on RegressionBench::benchRunAnalyse(phpdoc-inheritance-speedup.php) against the baseline committed in 196eba6

🤖 Generated with Claude Code

@ondrejmirtes
Copy link
Copy Markdown
Member Author

Test confirmed

Screenshot 2026-05-04 at 12 24 48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant