Update CSV dependency and remove is_terminal#157
Conversation
|
@phsym, could you please take a look at this PR? It seems to be minimalistic and it has a significant improvement of removing the (now-) redundant dependency. |
|
@loewenheim, it seems like you should also update the lock field in the child |
|
This would raise MSRV too much. |
|
Ah this had two changes and I didn't mean to close this - Also I guess we can bump MSRV in a year but not now. Can we make this only csv crate bump PR ? Did csv bump also bump MSRV ? Have to check. |
|
As for the Actually, my personal view here is that such low MSRV is not actually needed here, considering that the crate seems to be primarily used with binary crates, but since it's your policy, it's just my user-based opinion on this :) |
The
is_terminaldocumentation says