refactor: centralize bounded subprocess supervision (PR 1) - #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 1 of #32: deepen subprocess supervision without changing adapter policy or result mapping.
Centralizes bounded raw-byte stdout/stderr capture, timeout/cancellation/output/resource arbitration, Linux process groups, TERM→KILL tree cleanup, and complete stream draining. Migrates minimal, Droid, command-template, direct Droid provider, evaluator, WorkdirManager, and patch-capture process paths while leaving proxying, polling, metadata, Bubblewrap configuration, and provider execution boundaries in their adapters.
Focused process and adapter tests pass, including the required five-file command (75 tests), dual-stream backpressure, timeout/cancel precedence, deterministic sustained floods, descendant cleanup, TERM→KILL escalation, raw-byte capture, and Bubblewrap integration.
dart analyzepasses.dart testreaches 792 passes but the existing full-suite-load accessibility admission flake remains; its exact test passes alone, and untouchedorigin/mainreproduces that failure plus the existing headless prepare-timeout marker flake under the same full command.Local serious backend review completed with correctness, security/trust-boundary, issue-conformance, and simplification coverage; accepted race and precedence findings were fixed and revalidated.
Refs #32