fix(float): apply KWin skipswitcher rule to the XWayland fallback too - #66
Merged
Conversation
ensure_float_rule returned early whenever GDK_BACKEND=x11 was set, so the PICKGAUGE_X11=1 XWayland fallback never got the KWin skipswitcher rule. X11's EWMH has no skip-switcher hint, so the capsule kept showing up in KDE's Alt+Tab switcher even though skip-taskbar and skip-pager (which GTK does set over X11) worked fine. The rule now applies to any KDE Wayland session regardless of GDK_BACKEND, since KWin manages rules for native and XWayland clients alike. Documents per-platform task-switcher/taskbar support (KDE handled, Windows native, other Linux WMs standards-based only, macOS unsupported by Tauri) in code comments and the README, and fixes a stale README sentence describing the pre-#47 XWayland-by-default behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensure_float_rule()early-returned whenGDK_BACKEND=x11, so KDE Wayland sessions using thePICKGAUGE_X11=1XWayland fallback never received the KWinskipswitcherrule — and GTK's skip-taskbar maps only to EWMH SKIP_TASKBAR/PAGER (no switcher hint exists), so the KWin rule is the only mechanism; it matches by class+title on both native Wayland and XWaylandis_kde_wayland_session(xdg_session_type, xdg_current_desktop)(renderer backend is orthogonal to session type); 7 new unit tests; KDE-desktop filter for kwinrulesrc writes unchangedCloses #49. The accepted behavior is the reference for the PickScribe #46 port.
Validation
Local review: standard risk class — one independent correctness reviewer; verdict clean, zero findings (KDE-on-plain-X11 exclusion confirmed pre-existing and out of scope). KISS keep.