feat(macos): in-app global shortcut for dictation toggle - #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 4 of #66.
tauri-plugin-global-shortcutregistered on macOS only; handler drives the sameengine.togglepath as the single-instance--toggleforwarding (Linux keeps the DE-keybinding flow untouched)[shortcut]config section:toggle = "Cmd+Shift+Space"default on macOS, empty (off) elsewhere; partial-config deserialization pinned by testsupdate_app_configswaps registrations safely: register-new-before-unregister-old, rollback on settings persistence failure; startup registration failure logs and continuesdictation_supportedflips in PR 5 after the E2E loop is proven)Validated on macOS hardware: 132 engine + 38 shell tests, clippy
-D warningsclean, vitest 42/42, svelte-check clean. Live registration deliberately not exercised (would grab a real hotkey in the active session) — covered in the PR 5 E2E.🤖 Generated with Claude Code