Closed
Conversation
Contributor
|
Thanks for looking at it! There were a bunch of local dev files I see I checked in; I'll remove those. For Mathquill, looking at your screenshot, that's only actually used in the math-templated and math-input elements; the catagorize element (from the screenshot) uses mathjax. Then for the particular changes, I was trying to move to using mathquill in a way that doesn't rely on jquery global... |
Contributor
|
I'm actually working on a larger rewrite for MathQuill; that library is seriously outdated and is not actively maintained anymore, nor are its forks. We can take the core of MathQuill and update the UI code, get rid of the global jQuery requirement etc and make it a proper ESM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this jQuery changes fixed the mathquill errors I was getting locally:
