Conversation
Found an issue in the hottext inteaction - multiple selections item type. Changed the value of 0/3 to 0/4 being theres 4 options in total to select Also fixed the results rollup for all items so that when you test it out, it increases number of attempts, whether it was completed or not
All multilingual items working, debugging still in place. This is good for a PR, moving on to the "Other Items"
chillenious
requested changes
Feb 13, 2026
Contributor
chillenious
left a comment
chillenious
left a comment
There was a problem hiding this comment.
Looks good! The only thing I'd like you to go over is see if all the logging is needed (and if it is, if it should use console.debug rather than console.log.
Contributor
|
also, when you open a PR, CI will run tests, and currently CI/ Lint is failing (so PR isn't ready to go yet) |
Playwright test files use @axe-core/playwright which is a devDependency and may not be available during CI checks. Excluding these files from the main tsconfig prevents false positives in svelte-check.
Contributor
|
Sorry, the last request is to actually make the PR to merge into develop rather than master. We keep master as the trigger to actually publish packages, which we don't want to do for all changes. |
chillenious
added a commit
that referenced
this pull request
Feb 21, 2026
Bring across high-value PR #39 fixes for matching/media/hottext behavior and drawing file handling, and add targeted regression tests plus ts-check hardening to keep CI stable. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed all of the test items in the QTI Player
added 63 unit tests to cover the updated items and changes
all unit tests passing currently
13 Playwright tests failing (failing prior to changes), all working Playwright tests cover the new changes