fix: stabilize search/list material selection#444
Open
anthony-maio wants to merge 2 commits intopieces-app:mainfrom
Open
fix: stabilize search/list material selection#444anthony-maio wants to merge 2 commits intopieces-app:mainfrom
anthony-maio wants to merge 2 commits intopieces-app:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes the interactive material selection menu used by list/drive and search flows by constructing a deterministic (label, payload) list up-front, while avoiding unnecessary fallback asset snapshot work when an explicit asset list is provided.
Changes:
- Avoid eager fallback asset identifier resolution when
assetsare passed intoListCommand.list_assets. - Build a stable list of menu entries before rendering the selector (removing async
add_entryupdates). - Add a regression test asserting the selector receives
(label, asset_id)payloads.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/pieces/core/list_command.py |
Changes list_assets to build stable menu_entries up-front and removes the background thread that used add_entry. |
tests/assets/list_assets_test.py |
Adds a test asserting menu entries include asset_id payloads and that add_entry is no longer used. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(label, asset_id)entries before renderingTesting