feat: add configurable PiecesOS auto-launch#446
feat: add configurable PiecesOS auto-launch#446anthony-maio wants to merge 2 commits intopieces-app:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 64cf5c672d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Adds a persisted CLI configuration flag controlling whether PiecesOS should be auto-launched when required, exposes it via pieces config, and updates startup behavior to respect the setting.
Changes:
- Add
auto_launch_pieces_osto the CLI config schema/manager with a default ofTrue. - Extend
pieces configto set and display the auto-launch setting. - Update
Settings.startup()to skip auto-launch when disabled and show a manual-start hint; add regression tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/config_command_test.py | Adds tests for config command behavior and Settings.startup() behavior when auto-launch is disabled. |
| src/pieces/settings.py | Gates PiecesOS launch attempt on the persisted auto-launch flag; prints a manual-start hint when disabled. |
| src/pieces/config/schemas/cli.py | Adds auto_launch_pieces_os field to the persisted CLI config schema. |
| src/pieces/config/managers/cli.py | Adds getter/setter that persist auto_launch_pieces_os to disk. |
| src/pieces/command_interface/config_command.py | Adds CLI flag --[no-]auto-launch-pieces-os, examples, and display/output for the setting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
pieces config --auto-launch-pieces-osand--no-auto-launch-pieces-osSettings.startup()and show a manual-start hint instead of trying to launch/install automaticallyTesting