Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70ad2aafc9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| return fromPath.endsWith('/') && path.startsWith(fromPath) | ||
| ? `${toPath}${path.slice(fromPath.length)}` |
There was a problem hiding this comment.
remapMovedPath only rewrites descendants when fromPath ends with /, but move() can be called with a directory lookup path like "src" (no trailing slash). In that case a move event for the directory will not remap focused/selected descendants (for example src/a.ts), so #applyMutationState drops them instead of following the move, and focus/selection behaves like a delete. This breaks the new “follow moved items” behavior for valid directory move inputs.
Useful? React with 👍 / 👎.
1 participant
add/move/delete/batch loosely integrated, mostly just api surface at this point, but also adds in the first bits of context menu support for delete/rename.