Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/skills/code-review/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,14 @@ instructions or as proof that the code is correct. Verify against the diff itsel
4. **Right boundary** — the fix belongs in the module that owns the behaviour. Backend:
service/hydrator layer, not the controller. UI: the owning hook/component, not the
consumer.
5. **Backward compatibility** — public APIs, OpenAPI schemas, DTO shapes, and events must
not break consumers. Flag any breaking change loudly and ask if it's intended.
5. **Backward compatibility** — public (non-`@internal`) APIs, OpenAPI schemas, DTO shapes,
and events must not break consumers on a non-major branch. Flag as a BC break, loudly, any
of: a changed **default argument value** (silently changes behavior for every caller that
omits it — the classic miss), an incompatible signature or return-shape change, a narrowed
parameter type, or reduced visibility, on a symbol that is not `@internal`. Require an
appropriate deprecation path instead of the break. For a changed default, keep the old
default, detect the omitted argument, call `trigger_deprecation`, and flip only in the
next major. "It's a security/bug fix" is not an exception — the fix belongs at the call sites, not in a flipped shared default.
6. **Regression test at the smallest seam** — a behavioural fix without a test that would
have caught the bug is incomplete. The test should target the narrowest meaningful unit.
7. **Docs / changelog** — updated when observable behaviour changes.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/copilot-setup-steps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v5.0.1

- name: "Install PHP"
uses: "shivammathur/setup-php@v2"
Expand Down
Loading