fix: normalize agent IDs and remove bootstrap files for benchmark#37
Open
zhuanghaoz wants to merge 2 commits intopinchbench:mainfrom
Open
fix: normalize agent IDs and remove bootstrap files for benchmark#37zhuanghaoz wants to merge 2 commits intopinchbench:mainfrom
zhuanghaoz wants to merge 2 commits intopinchbench:mainfrom
Conversation
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)No additional issues found outside the diff. Files Reviewed (2 files)
|
- Fix agent ID normalization to handle lowercase transformation - Remove BOOTSTRAP.md, SOUL.md, USER.md, IDENTITY.md before running tasks - Fix model ID normalization to preserve provider-qualified models (e.g., minimax-cn/) These fixes ensure benchmark tasks work correctly with OpenClaw agents.
zhuanghaoz
force-pushed
the
fix/agent-id-normalization
branch
from
0c5418b to
0cccb85
Compare
- Copy skills from main workspace to benchmark workspace so agents can use nano-pdf - Add 2-second delay before grading to ensure files are flushed to disk - Fix model ID normalization to preserve provider-qualified models
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| import os | ||
| import statistics | ||
| import subprocess | ||
| import time |
Contributor
There was a problem hiding this comment.
WARNING: Duplicate import time — this line adds import time but it already exists at line 23. The duplicate should be removed.
Suggested change
| import time |
Member
|
@zhuanghaoz thanks for this contribution I am wondering if "Remove BOOTSTRAP.md, SOUL.md, USER.md, IDENTITY.md before running tasks" is a good idea - I had problems early in this project with OpenClaw not linking not having those and getting lost on actual task completion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fixes ensure benchmark tasks work correctly with OpenClaw agents.