Conversation
- Fix agent ID normalization to handle lowercase transformation - Remove BOOTSTRAP.md, SOUL.md, USER.md, IDENTITY.md before running tasks - Fix model ID normalization to preserve provider-qualified models (e.g., minimax-cn/) These fixes ensure benchmark tasks work correctly with OpenClaw agents.
- Copy skills from main workspace to benchmark workspace so agents can use nano-pdf - Add 2-second delay before grading to ensure files are flushed to disk - Fix model ID normalization to preserve provider-qualified models
Fix/agent id normalization
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| import os | ||
| import statistics | ||
| import subprocess | ||
| import time |
There was a problem hiding this comment.
WARNING: Duplicate import time — this line adds import time, but it already exists at line 23. The PR introduces a redundant import.
| import time |
| if skill_dir_src.is_dir(): | ||
| dest_skill_dir = dest_skills_dir / skill_dir_src.name | ||
| # Copy skill directory | ||
| import shutil |
There was a problem hiding this comment.
WARNING: import shutil inside a loop — this import statement is executed on every iteration of the for skill_dir_src in main_skills_dir.iterdir() loop. While Python caches module imports, placing it here is unnecessary overhead and poor practice. Move it to the top of the file with the other imports.
There was a problem hiding this comment.
@zhuanghaoz what do you think about moving this to the top of the file to import it once?
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (2 files)
|
olearycrew
left a comment
olearycrew
left a comment
There was a problem hiding this comment.
@zhuanghaoz can you fix the conflicts as well here?
Thanks for this contribution!
2 participants
No description provided.