Skip to content

Set metric on createIndex#7

Open
julioxavierr wants to merge 1 commit intopinecone-io:mainfrom
julioxavierr:fix/metric
Open

Set metric on createIndex#7
julioxavierr wants to merge 1 commit intopinecone-io:mainfrom
julioxavierr:fix/metric

Conversation

@julioxavierr
Copy link

Problem

Describe the purpose of this change. What problem is being solved and why?

Resolves #6

Solution

Describe the approach you took. Link to any relevant bugs, issues, docs, or other resources.

Included the metric parameter to the createIndex call.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.

  • Follow the instructions in README. The index creation should fail.

@dhurlburtusa
Copy link

It would be great to get this merged so that potential customers don't shy away from broken examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Missing metric parameter in pinecone.createIndex

2 participants