Add user tags to post_photo function#108
Open
deounix wants to merge 3 commits intoping:masterfrom
deounix:post_photo_user_tags
Open
Add user tags to post_photo function#108deounix wants to merge 3 commits intoping:masterfrom deounix:post_photo_user_tags
deounix wants to merge 3 commits intoping:masterfrom
deounix:post_photo_user_tags
Conversation
Update
Add random number that is cryptographically secure in python.
ping
reviewed
Jan 30, 2019
| if len(user_tags) > 60: | ||
| warnings.warn('Adding more than 60 users will put your account at banned risk', UserWarning) | ||
| for user_id in user_tags: | ||
| user_tags_["in"].append({"user_id": user_id, "position": [cryptogen.random(), cryptogen.random()]}) |
Owner
There was a problem hiding this comment.
Forcibly putting user tags at random positions is not a good idea at all imo.
There was a problem hiding this comment.
maybe adding an array with the x and y positions of each tag? i like the tagging idea, but i agree with you, adding it at random is very bad.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add user tags to post_photo function (WEB API ONLY)