Skip to content

i18n(ja): restore variable names and clean up heading anchors in system variable docs - #23295

Merged
qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-fix-varname-headings
Jul 29, 2026
Merged

i18n(ja): restore variable names and clean up heading anchors in system variable docs#23295
qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-fix-varname-headings

Conversation

@yahonda

@yahonda yahonda commented Jul 16, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Japanese heading fixes for system-variable-reference.md and system-variables.md, in two parts:

1. Restore English system variable names in headings (original scope)

  • system-variable-reference.md: 109 headings
  • system-variables.md: 45 headings

2. Clean up heading anchors and version marks (follow-up)

The explicit {#...} anchors on English variable headings had converted underscores to hyphens (e.g. ### auto_increment_increment {#auto-increment-increment}), which does not match how the site auto-generates anchors (underscores are preserved) nor the underscore-form links used throughout the docs ([...](#auto_increment_increment)). As a result those cross-references were broken. Since the auto-generated anchor is already correct, the redundant {#...} anchors are removed.

For version-marked headings, the anchor only existed because New in vX.Y.Z had been translated into Japanese (e.g. vX.Y.Zで追加, or sentence forms leaving a stray ), which changed the auto-anchor. The version-mark text is restored to the English New in vX.Y.Z (matching the release-8.5 source) and the anchor is dropped. Two corrupted headings (zero-width spaces splitting a variable name, and an anchor that had captured the <span> markup) are also fixed.

Verification: all 84 same-file links and 1,642 repo-wide cross-file links into these two files resolve; no residual translated version marks, mangled anchors, or zero-width spaces remain.

This is a Japanese (ja) translation-only fix; no English source content is changed.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from: N/A (Japanese translation heading/anchor fix only)
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Note on scope

A few of the lines in this PR also carry a fix that belongs to one of the sibling ja PRs. Where a later sweep found damage on a line this PR already edits, the fix was applied here rather than duplicated into another PR — otherwise the two PRs would conflict. So a small number of lines go beyond the scope stated above, for example:

-…発生します。1パラメータ`gc.max_write_bytes_per_sec`使用すると、…
+…発生します。`gc.max_write_bytes_per_sec`パラメータを使用すると、…

Here the stray 1 (a translation-tool placeholder) and the word order were repaired alongside this PR's particle insertion.

All fifteen ja PRs were verified to merge cleanly in any order (105 pairwise merges, 0 conflicts).

@ti-chi-bot

ti-chi-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. labels Jul 16, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lance6716 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Japanese documentation files system-variable-reference.md and system-variables.md by replacing translated Japanese headings for system variables with their actual English system variable names (for example, changing '自動コミット' to 'autocommit'). This ensures consistency and technical accuracy across the reference documents. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@ti-chi-bot ti-chi-bot Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 16, 2026
@yahonda yahonda changed the title i18n(ja): restore system variable names in headings (system-variable-reference.md 109, system-variables.md 45) i18n(ja): restore variable names and clean up heading anchors in system variable docs Jul 16, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 16, 2026
@yahonda
yahonda force-pushed the i18n-ja-fix-varname-headings branch from 9861520 to 9d2131f Compare July 16, 2026 14:31
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: eb7a2144-7e7d-40e4-bf1b-3b7838c65e22

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…iable docs

Rebased onto the current i18n-ja-release-8.5 (ce3803c). Variable-name headings are
restored to match the English source (English version-mark, explicit anchors removed so
the auto-generated anchor matches English); all internal system-variables anchors resolve.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@yahonda
yahonda force-pushed the i18n-ja-fix-varname-headings branch from 3ac1ec9 to 2300fa1 Compare July 29, 2026 08:45
@yahonda
yahonda marked this pull request as ready for review July 29, 2026 08:45
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 29, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-07-29 14:08:10.244300315 +0000 UTC m=+2018676.280395371: ☑️ agreed by qiancai.

@qiancai
qiancai merged commit 41695a8 into pingcap:i18n-ja-release-8.5 Jul 29, 2026
3 of 8 checks passed
@yahonda
yahonda deleted the i18n-ja-fix-varname-headings branch July 30, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants