server: check connection is available in SQLKiller (#60685)#65862
Merged
ti-chi-bot[bot] merged 1 commit intoJan 29, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-8.5-20260116-v8.5.5 #65862 +/- ##
================================================================
Coverage ? 72.5168%
================================================================
Files ? 1683
Lines ? 469473
Branches ? 0
================================================================
Hits ? 340447
Misses ? 106363
Partials ? 22663
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/retest |
Defined2014
approved these changes
Jan 29, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
bd3f040
into
pingcap:release-8.5-20260116-v8.5.5
18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #60685, and the conflicts are resolved by:
pkg/server/conn_stmt.go: kept the new SQLKiller connection‑alive hook (IsConnectionAlive.Store(&fn)with defer reset) inserted before executing the prepared statement, so the checker usesbufReadConn.IsAlive()during plan‑cache prepared statement execution.pkg/server/tests/commontest/tidb_test.go: preserved the existing audit plugin tests (TestAuditPluginInfoForStarting,TestAuditPluginRetrying) from the release branch and appended the newTestIssue57531test from the cherry‑picked commit, so both sets of tests remain.What problem does this PR solve?
Issue Number: close #57531
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.