Skip to content

ttl: stabilize TestCancelWhileScan runtime #67657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zanmato1984 wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −9
Open

ttl: stabilize TestCancelWhileScan runtime #67657

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fca6b36
ttl: stabilize TestCancelWhileScan runtime
zanmato1984 Apr 9, 2026
10aeb41
ttl: remove long-mode branch from cancel scan test
zanmato1984 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions pkg/ttl/ttlworker/scan_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"context"
"fmt"
"math/rand/v2"
"strings"
"sync"
"testing"
"time"
Expand All @@ -26,7 +27,6 @@ import (
"github.com/pingcap/tidb/pkg/sessionctx/vardef"
"github.com/pingcap/tidb/pkg/testkit"
"github.com/pingcap/tidb/pkg/testkit/testfailpoint"
"github.com/pingcap/tidb/pkg/testkit/testflag"
"github.com/pingcap/tidb/pkg/ttl/cache"
"github.com/pingcap/tidb/pkg/ttl/ttlworker"
"github.com/stretchr/testify/require"
Expand All @@ -39,11 +39,17 @@ func TestCancelWhileScan(t *testing.T) {
tk.MustExec("create table test.t (id int, created_at datetime) TTL= created_at + interval 1 hour")
testTable, err := dom.InfoSchema().TableByName(context.Background(), ast.NewCIStr("test"), ast.NewCIStr("t"))
require.NoError(t, err)
for i := range 10000 {
tk.MustExec(fmt.Sprintf("insert into test.t values (%d, NOW() - INTERVAL 24 HOUR)", i))
const totalRows, batchSize = 1000, 100
for i := 0; i < totalRows; i += batchSize {
values := make([]string, 0, batchSize)
for j := i; j < i+batchSize; j++ {
values = append(values, fmt.Sprintf("(%d, NOW() - INTERVAL 24 HOUR)", j))
}
tk.MustExec("insert into test.t values " + strings.Join(values, ","))
}
testPhysicalTableCache, err := cache.NewPhysicalTable(ast.NewCIStr("test"), testTable.Meta(), ast.NewCIStr(""))
require.NoError(t, err)
testfailpoint.Enable(t, "github.com/pingcap/tidb/pkg/store/copr/sleepCoprRequest", "return(200)")

delCh := make(chan *ttlworker.TTLDeleteTask)
wg := &sync.WaitGroup{}
Expand All @@ -55,12 +61,8 @@ func TestCancelWhileScan(t *testing.T) {
}
}()

testStart := time.Now()
testDuration := time.Second
if testflag.Long() {
testDuration = time.Minute
}
for time.Since(testStart) < testDuration {
rounds := 10
for i := 0; i < rounds; i++ {
ctx, cancel := context.WithCancel(context.Background())
ttlTask := ttlworker.NewTTLScanTask(ctx, testPhysicalTableCache, &cache.TTLTask{
JobID: "test",
Expand Down
Loading