fix(windows): windows branch switch ui broken#1038
fix(windows): windows branch switch ui broken#1038EwanJordaan wants to merge 3 commits intopingdotgg:mainfrom
Conversation
- Apply shared hover/selected/highlight class to all branch combobox items - Keep branch action rows and branch rows visually consistent in the selector
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.Change the |
What Changed
Why
The branch switcher already controls selection through the combobox value state, but the selected styling was partly hardcoded in the branch selector itself. That made the UI behavior inconsistent and more fragile.
This change moves selected-state styling into the shared combobox/autocomplete primitives so visual state is handled consistently through the existing
data-selected,data-highlighted, and hover behaviors.By relying on the shared primitives instead of custom styling in the branch selector, the UI behavior becomes predictable across combobox-based components and resolves the Windows branch selection hover issue.
UI Changes
Before:
After:
Video:
Screen.Recording.2026-03-13.195339.mp4
Checklist
Issue #1040
Note
Fix branch selector UI styling on Windows
branchSelectorHighlightClassNameconstant to BranchToolbarBranchSelector.tsx with dark (#242424) background and white text for hover, selected, and highlighted states, replacing a broken conditionalbg-accentclass.hover:bg-accent,data-selected:bg-accent/50, anddata-selected:text-foregroundto item base styles.Macroscope summarized d3f6d4f.