Avoid packaged Windows console pipe crashes#4206
Draft
SunkenInTime wants to merge 2 commits into
Draft
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
EPIPE; after the inherited pipe breaks, only the unavailable console sink is disabled while the tracer continues writingdesktop.trace.ndjson.EPIPEcase and unrelated console failures that must still surface.Why
The packaged Electron main process installs Effect's
consolePrettylogger. On Windows, a launch path that gives the app piped stdout or stderr can leave it with a broken pipe after the reader exits. The next Effect log callsconsole.logsynchronously and escapes as an uncaughtEPIPE, producing Electron's "A JavaScript error occurred in the main process" dialog.This was reproduced with
0.0.29-nightly.20260720.853by launching T3 Code Nightly with piped output, closing the parent-side reader after startup, and allowing the desktop updater to emit another main-process Effect log.The guarded logger preserves normal console output for Windows launches with a usable pipe. It catches only errors whose code is
EPIPE, stops retrying that dead sink after the first failure, and rethrows every other console error.UI Changes
No product UI changes. These artifacts show the existing Windows failure:
Verification
vp exec vitest run apps/desktop/src/app/DesktopObservability.test.tsvp run --filter @t3tools/desktop typecheckvp fmt --check apps/desktop/src/app/DesktopObservability.ts apps/desktop/src/app/DesktopObservability.test.tsvp lint apps/desktop/src/app/DesktopObservability.ts apps/desktop/src/app/DesktopObservability.test.tsvp pack.T3 Code (Alpha)window whiledesktop.trace.ndjsoncontinued receiving events for another 17 seconds without an Electron error dialog.Checklist