Skip to content

feat: new uploadFiles API #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
May 1, 2025
+2,543 −221
Merged

feat: new uploadFiles API #1176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/happy-houses-hang.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"uploadthing": minor
---

feat: introduce new experimental client API

This API is not covered under semver. Check out some example usage here:

https://github.com/pingdotgg/uploadthing/blob/main/playground/app/originui/page.tsx
Copy link
Contributor

@coderabbitai coderabbitai bot May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify that the example URL is correct

The URL points to /originui/page.tsx but the PR summary mentions examples in playground/app/future/page.tsx. Please verify this is the correct example location.

🏁 Script executed:

#!/bin/bash
# Check if both paths exist and compare them
echo "Checking if the files exist:"
ls -la playground/app/originui/page.tsx 2>/dev/null
ls -la playground/app/future/page.tsx 2>/dev/null

# Check if they contain examples of the new API
echo -e "\nChecking for usage of future_genUploader in files:"
grep -n "future_genUploader" playground/app/originui/page.tsx 2>/dev/null
grep -n "future_genUploader" playground/app/future/page.tsx 2>/dev/null

Length of output: 550

Update the example URL in the changeset

It looks like the linked example in .changeset/happy-houses-hang.md still points to:

https://github.com/pingdotgg/uploadthing/blob/main/playground/app/originui/page.tsx

but according to the PR summary the new API example lives in playground/app/future/page.tsx. Please update the URL on line 9 of that changeset to:

- https://github.com/pingdotgg/uploadthing/blob/main/playground/app/originui/page.tsx
+ https://github.com/pingdotgg/uploadthing/blob/main/playground/app/future/page.tsx

and verify the linked file shows the intended example.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
https://github.com/pingdotgg/uploadthing/blob/main/playground/app/originui/page.tsx
https://github.com/pingdotgg/uploadthing/blob/main/playground/app/future/page.tsx
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

9-9: Bare URL used
null

(MD034, no-bare-urls)

2 changes: 1 addition & 1 deletion examples/profile-picture/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@auth/drizzle-adapter": "^1.2.0",
"@libsql/client": "^0.14.0",
"@uploadthing/react": "7.3.0",
"class-variance-authority": "^0.7.0",
"class-variance-authority": "^0.7.1",
"client-only": "^0.0.1",
"drizzle-orm": "^0.38.3",
"lucide-react": "^0.469.0",
Expand Down
2 changes: 1 addition & 1 deletion examples/with-novel/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"dependencies": {
"@tailwindcss/typography": "^0.5.15",
"@uploadthing/react": "7.3.0",
"class-variance-authority": "^0.7.0",
"class-variance-authority": "^0.7.1",
"cmdk": "^1.1.1",
"lucide-react": "^0.469.0",
"next": "15.3.1",
Expand Down
15 changes: 13 additions & 2 deletions packages/uploadthing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,16 @@
"default": "./client/index.cjs"
}
},
"./client-future": {
"import": {
"types": "./client-future/index.d.ts",
"default": "./client-future/index.js"
},
"require": {
"types": "./client-future/index.d.cts",
"default": "./client-future/index.cjs"
}
},
"./server": {
"import": {
"types": "./server/index.d.ts",
Expand Down Expand Up @@ -118,6 +128,7 @@
},
"files": [
"client",
"client-future",
"dist",
"effect-platform",
"express",
Expand All @@ -135,9 +146,9 @@
},
"scripts": {
"lint": "eslint src test --max-warnings 0",
"build": "NODE_OPTIONS='--max_old_space_size=8192' bunchee --tsconfig tsconfig.build.json && cp src/tw/v4.css tw/v4.css",
"build": "NODE_OPTIONS='--max_old_space_size=16384' bunchee --tsconfig tsconfig.build.json && cp src/tw/v4.css tw/v4.css",
"clean": "git clean -xdf client express fastify h3 internal next next-legacy server tw node_modules",
"dev": "NODE_OPTIONS='--max_old_space_size=8192' bunchee --tsconfig tsconfig.build.json --no-clean && cp src/tw/v4.css tw/v4.css",
"dev": "NODE_OPTIONS='--max_old_space_size=16384' bunchee --tsconfig tsconfig.build.json --no-clean && cp src/tw/v4.css tw/v4.css",
"prepack": "bun ../../.github/replace-workspace-protocol.ts",
"test": "vitest run",
"typecheck": "tsc --noEmit"
Expand Down
Loading
Loading