-
Notifications
You must be signed in to change notification settings - Fork 410
Docs/update tanstack guide #1266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TokiLoshi
wants to merge
5
commits into
pingdotgg:main
Choose a base branch
from
TokiLoshi:docs/update-tanstack-guide
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11,072
−5,985
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7d6266c
docs: updating minimal example and documentation for latest tanstack …
TokiLoshi d164f6b
docs: adding changeset and update to README
TokiLoshi ef5dd92
chore: removing commented code from tsconfig
TokiLoshi 7c2dece
fix: add missing UploadThing CSS import and correct README link
TokiLoshi a5a973d
Delete .changeset/social-buckets-rest.md
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,12 @@ | ||
| import { createRouter as createTanStackRouter } from "@tanstack/react-router"; | ||
| import { createRouter } from "@tanstack/react-router"; | ||
|
|
||
| import { routeTree } from "./routeTree.gen"; | ||
|
|
||
| export function createRouter() { | ||
| const router = createTanStackRouter({ | ||
| export function getRouter() { | ||
| const router = createRouter({ | ||
| routeTree, | ||
| scrollRestoration: true, | ||
| }); | ||
|
|
||
| return router; | ||
| } | ||
|
|
||
| declare module "@tanstack/react-router" { | ||
| interface Register { | ||
| router: ReturnType<typeof createRouter>; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 0 additions & 12 deletions
12
examples/minimal-tanstack-start/src/routes/api.uploadthing.ts
This file was deleted.
Oops, something went wrong.
20 changes: 20 additions & 0 deletions
20
examples/minimal-tanstack-start/src/routes/api/uploadthing.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import { createFileRoute } from "@tanstack/react-router"; | ||
|
|
||
| import { createRouteHandler } from "uploadthing/server"; | ||
|
|
||
| import { uploadRouter } from "../../server/uploadthing"; | ||
|
|
||
| const handler = createRouteHandler({ router: uploadRouter }); | ||
|
|
||
| export const Route = createFileRoute("/api/uploadthing")({ | ||
| server: { | ||
| handlers: { | ||
| GET: async ({ request }: { request: Request }) => { | ||
| return handler(request); | ||
| }, | ||
| POST: ({ request }: { request: Request }) => { | ||
| return handler(request); | ||
| }, | ||
| }, | ||
| }, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,16 @@ | ||
| import { tanstackStart } from "@tanstack/react-start/plugin/vite"; | ||
| import viteReact from "@vitejs/plugin-react"; | ||
| import { defineConfig } from "vite"; | ||
| import tsConfigPaths from "vite-tsconfig-paths"; | ||
|
|
||
| export default defineConfig({ | ||
| server: { | ||
| port: 3000, | ||
| }, | ||
| plugins: [tanstackStart()], | ||
| plugins: [ | ||
| tsConfigPaths(), | ||
| tanstackStart(), | ||
| // react's vite plugin must come after start's vite plugin | ||
| viteReact(), | ||
| ], | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UploadThing CSS styles are missing. The documentation shows CSS should be imported for proper component styling, but the import was removed from this file and not replaced anywhere else.
The old code had:
According to the documentation at
docs/src/app/(docs)/getting-started/tanstack-start/page.mdx, you should add:Prompt To Fix With AI