fix to manual parse a query string to cast varchar column input value…#63
Open
sachinsagare wants to merge 3 commits into
Open
fix to manual parse a query string to cast varchar column input value…#63sachinsagare wants to merge 3 commits into
sachinsagare wants to merge 3 commits into
Conversation
…s in single quotes. This should be temporary fix, and we need to request client to use single quote for all varchar columns in where clause. Signed-off-by: ssagare <ssagare@pinterest.com>
Signed-off-by: ssagare <ssagare@pinterest.com>
…tatype, so removed column type validation logic to allow code to append single quotes to all the where conditions. Signed-off-by: ssagare <ssagare@pinterest.com>
debasatwa29
reviewed
Dec 8, 2022
| @@ -4362,7 +4362,7 @@ public void testFilterOnStringAsNumber() throws Exception | |||
| ) | |||
| .setDimFilter( | |||
There was a problem hiding this comment.
Please add some Unit tests for your changes. The Unit test should contain some expected queries passing and some expected queries failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes to manual parse a query string to cast varchar column input values into single quotes. This should be temporary fix, and we need to request client to use single quote for all varchar columns in where clause.
Signed-off-by: ssagare ssagare@pinterest.com
Fixes #XXXX.
Description
Fixed the bug ...
Renamed the class ...
Added a forbidden-apis entry ...
Release note
For tips about how to write a good release note, see Release notes.
Key changed/added classes in this PR
MyFooOurBarTheirBazThis PR has: