Skip to content

Changed creating decoder to return a pointer #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FrantaBOT wants to merge 1 commit into from
Closed

Changed creating decoder to return a pointer #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conformance_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ func decodeRFC6716Vector(t *testing.T, rate, channels int, bitstream, outPath st
t.Fatalf("frame %d: Go decode: %v", frame, err)
}

gotFinalRange, err := conformanceFinalRange(&decoder)
gotFinalRange, err := conformanceFinalRange(decoder)
if err != nil {
t.Fatalf("frame %d: final range unavailable: %v", frame, err)
}
Expand Down
8 changes: 4 additions & 4 deletions decoder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,21 +64,21 @@ type silkCeltAddition struct {
}

// NewDecoder creates a new Opus Decoder.
func NewDecoder() Decoder {
func NewDecoder() *Decoder {
decoder, _ := NewDecoderWithOutput(BandwidthFullband.SampleRate(), 1)

return decoder
}

// NewDecoderWithOutput creates a new Opus Decoder with the requested output sample rate and channel count.
func NewDecoderWithOutput(sampleRate, channels int) (Decoder, error) {
decoder := Decoder{
func NewDecoderWithOutput(sampleRate, channels int) (*Decoder, error) {
decoder := &Decoder{
silkDecoder: silk.NewDecoder(),
silkBuffer: make([]float32, maxSilkFrameSampleCount),
celtDecoder: celt.NewDecoder(),
}
if err := decoder.Init(sampleRate, channels); err != nil {
return Decoder{}, err
return nil, err
}

return decoder, nil
Expand Down
Loading