Add stereo mid/side encoding#126
Open
thomas-vilte wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
==========================================
+ Coverage 82.88% 83.77% +0.89%
==========================================
Files 29 29
Lines 6110 6398 +288
==========================================
+ Hits 5064 5360 +296
+ Misses 811 801 -10
- Partials 235 237 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds stereo encoding to the CELT layer.
WithChannels(2)now produces valid stereo packets end-to-end: the public API deinterleaves the input, analysis runs per-channel, andquantAllBandsStereohandles mid/side coupling — mirroring the decoder's existingquantBandstereo path.The theta encoder implements the same three probability models as
decodeBandTheta(stereo-large with p0=3 at extremes, uniform, triangular). The stereo path usesmidGain=1,level=0for recursive calls, and nil lowband for the side channel — matching what the decoder expects. AFinalRangecomparison test between encoder and decoder catches any range coder divergence after a stereo frame.Intensity stereo and the dual-stereo L1 decision are left for follow-up PRs. For now,
intensity=maxBands(disabled) and mid/side coupling is always used.Reference issue
Fixes #...