Skip to content

Update go to v1.26.2 - #6711

Merged
khanhtc1202 merged 11 commits into
masterfrom
update-go-version
May 30, 2026
Merged

Update go to v1.26.2#6711
khanhtc1202 merged 11 commits into
masterfrom
update-go-version

Conversation

@khanhtc1202

@khanhtc1202 khanhtc1202 commented Apr 23, 2026

Copy link
Copy Markdown
Member

What this PR does:

Since Snyk asked to update Go to v1.26.2 for a security update, I think it's time to migrate all pipecd components to v1.26.

Tested:

  • code gen no change (local test only, since this PR introduces new container image, which required to update the codegen CI container image version to ensure running)
  • control plane behavior no change
  • piped behavior no change

Not yet tested:

  • CI workflow (will check by this PR CI)

Uncovered modules:

  • None

Why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@codecov

codecov Bot commented Apr 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.33%. Comparing base (f52e999) to head (f02d6ee).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../app/piped/platformprovider/terraform/terraform.go 0.00% 12 Missing ⚠️
...app/pipedv1/plugin/terraform/provider/terraform.go 0.00% 12 Missing ⚠️
pkg/app/piped/platformprovider/kubernetes/diff.go 0.00% 5 Missing ⚠️
tool/actions-gh-release/release.go 42.85% 4 Missing ⚠️
pkg/app/ops/firestoreindexensurer/gcloud.go 0.00% 3 Missing ⚠️
tool/actions-plan-preview/planpreview.go 0.00% 3 Missing ⚠️
pkg/app/piped/trigger/trigger.go 0.00% 2 Missing ⚠️
pkg/app/pipedv1/trigger/trigger.go 0.00% 2 Missing ⚠️
pkg/app/piped/controller/scheduler.go 0.00% 1 Missing ⚠️
pkg/app/piped/driftdetector/cloudrun/detector.go 0.00% 1 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6711      +/-   ##
==========================================
+ Coverage   29.32%   29.33%   +0.01%     
==========================================
  Files         601      601              
  Lines       64190    64204      +14     
==========================================
+ Hits        18822    18834      +12     
+ Misses      43904    43903       -1     
- Partials     1464     1467       +3     
Flag Coverage Δ
. 23.15% <43.33%> (+0.01%) ⬆️
.-pkg-app-pipedv1-plugin-analysis 32.43% <ø> (ø)
.-pkg-app-pipedv1-plugin-ecs 31.82% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 58.37% <83.33%> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 59.39% <100.00%> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.18% <7.69%> (+0.23%) ⬆️
.-pkg-app-pipedv1-plugin-wait 33.04% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 52.71% <ø> (ø)
.-pkg-plugin-sdk 50.34% <100.00%> (ø)
.-tool-actions-gh-release 19.23% <50.00%> (ø)
.-tool-actions-plan-preview 25.51% <0.00%> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@mohammedfirdouss

Copy link
Copy Markdown
Contributor

@khanhtc1202 lint issues

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202

Copy link
Copy Markdown
Member Author

Required to merge the PR #6717 before in order to make gen/code pipeline pass

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202
khanhtc1202 enabled auto-merge (squash) May 28, 2026 03:28
@khanhtc1202

Copy link
Copy Markdown
Member Author

NOTE: re-enable codegen CI as a required step after this PR is merged (the codegen container image is generated)

@Warashi Warashi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanhtc1202
khanhtc1202 merged commit 0d71fd0 into master May 30, 2026
74 of 75 checks passed
@khanhtc1202
khanhtc1202 deleted the update-go-version branch May 30, 2026 22:16
@khanhtc1202 khanhtc1202 mentioned this pull request Jun 1, 2026
@github-actions github-actions Bot mentioned this pull request Jun 25, 2026
harshitghagre pushed a commit to harshitghagre/pipecd that referenced this pull request Jun 28, 2026
* Update go to v1.26.2

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Update go lint version for CI

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Update go version for plugins

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Fix test

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Fix lints

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Fix lints

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Fix lints

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Fix lints

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Fix lints

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Fix lint

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

---------

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: harshitghagre <harshitghagre183@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants