Move course unit test mocks to tests/samples/ and delete outdated, unused mocks#221
Open
tianyizheng02 wants to merge 2 commits intodevfrom
Open
Move course unit test mocks to tests/samples/ and delete outdated, unused mocks#221tianyizheng02 wants to merge 2 commits intodevfrom
course unit test mocks to tests/samples/ and delete outdated, unused mocks#221tianyizheng02 wants to merge 2 commits intodevfrom
Conversation
Delete the HTML mock files for unit tests for the course module, which are left over from the old implementation of the course module using PSMobile. These mocks are now unused and unusable for the current implementation, since the current implementation works with JSON and not HTML.
Move the Python file of mocks for unit tests for the course module to the tests/samples directory so that it's in the same directory as most other mocks. This is part of a larger effort to migrate all mocks in tests/mocks to tests/samples so that all mocks are under the same directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the Python file of mocks for unit tests for the
coursemodule to thetests/samplesdirectory so that it's in the same directory as most other mocks. This is part of a larger effort to migrate all mocks intests/mockstotests/samplesso that all mocks are under the same directory.I also deleted the HTML mock files for unit tests for the
coursemodule, which are left over from the old implementation of thecoursemodule using PSMobile. These mocks are now unused and unusable for the current implementation, since the current implementation works with JSON and not HTML.