pixelcola · pixelcola · May 12, 2026 · May 12, 2026 · May 12, 2026 · May 12, 2026
diff --git a/.trellis/tasks/archive/2026-05/05-12-improve-tests/check.jsonl b/.trellis/tasks/archive/2026-05/05-12-improve-tests/check.jsonl
@@ -0,0 +1 @@
+{"_example": "Fill with {\"file\": \"<path>\", \"reason\": \"<why>\"}. Put spec/research files only — no code paths. Run `python3 .trellis/scripts/get_context.py --mode packages` to list available specs. Delete this line once real entries are added."}
diff --git a/.trellis/tasks/archive/2026-05/05-12-improve-tests/implement.jsonl b/.trellis/tasks/archive/2026-05/05-12-improve-tests/implement.jsonl
@@ -0,0 +1 @@
+{"_example": "Fill with {\"file\": \"<path>\", \"reason\": \"<why>\"}. Put spec/research files only — no code paths. Run `python3 .trellis/scripts/get_context.py --mode packages` to list available specs. Delete this line once real entries are added."}
diff --git a/.trellis/tasks/archive/2026-05/05-12-improve-tests/prd.md b/.trellis/tasks/archive/2026-05/05-12-improve-tests/prd.md
@@ -0,0 +1,50 @@
+# 补充完善测试用例
+
+## Goal
+
+补充 `sing-cli` 现有 CLI、state、profile、service 模块的测试覆盖，锁定当前命令契约和错误处理行为，降低后续重构或修复时引入回归的风险。
+
+## Requirements
+
+* 只新增或调整测试，不改变当前业务行为。
+* 覆盖主要 CLI 命令的成功路径：`install`、`add`、`remove`、`update`、`list`。
+* 覆盖关键错误路径：已存在 profile、删除 active profile、未安装 bin 启动、下载 HTTP 错误、无效 state 字段、非 Windows 服务操作、缺失 `sing-box.exe`。
+* 测试继续使用现有 pytest、Typer `CliRunner`、monkeypatch 和临时目录模式。
+* 不添加 mock 成功路径到生产代码；外部依赖通过测试替身注入或 monkeypatch 隔离。
+
+## Acceptance Criteria
+
+* [ ] 新增测试能在本地稳定运行，不依赖真实 Windows、真实 NSSM、真实网络或真实用户 app data。
+* [ ] `uv run pytest` 通过。
+* [ ] `uv run ruff check src tests` 通过。
+* [ ] `uv run ty check src tests` 或项目可用的类型检查命令通过；若工具不支持测试路径，使用项目约定命令并记录结果。
+
+## Definition of Done
+
+* Tests added or updated.
+* Lint, type-check, and test suite pass.
+* No production behavior changed unless tests expose an existing bug that must be fixed explicitly.
+* No docs update unless behavior or documented command contract changes.
+
+## Technical Approach
+
+以现有测试风格为基准扩展覆盖：CLI 测试通过 `CliRunner` 调用命令并 monkeypatch `app_dir`、service/profile 函数；模块测试使用轻量 stub 验证状态解析、下载错误和 service 参数/平台边界。
+
+## Decision (ADR-lite)
+
+**Context**: 当前测试已经覆盖部分核心路径，但 CLI 命令集合和错误处理矩阵尚未完整锁定。  
+**Decision**: 本任务优先补充行为测试，不引入新测试框架、不修改生产代码。  
+**Consequences**: 覆盖面提升且变更风险低；如果测试暴露真实行为缺陷，再以最小生产代码修改修复。
+
+## Out of Scope
+
+* 不新增功能。
+* 不重构生产代码。
+* 不引入覆盖率工具或强制覆盖率阈值。
+* 不测试真实 Windows service 或真实网络下载。
+
+## Technical Notes
+
+* 项目使用 Python `>=3.13`，测试框架为 pytest。
+* 现有测试文件：`tests/test_cli.py`、`tests/test_profile.py`、`tests/test_state.py`、`tests/test_service.py`。
+* 相关规范：`.trellis/spec/backend/index.md`、`.trellis/spec/backend/quality-guidelines.md`、`.trellis/spec/backend/error-handling.md`。
diff --git a/.trellis/tasks/archive/2026-05/05-12-improve-tests/task.json b/.trellis/tasks/archive/2026-05/05-12-improve-tests/task.json
@@ -0,0 +1,26 @@
+{
+  "id": "improve-tests",
+  "name": "improve-tests",
+  "title": "补充完善测试用例",
+  "description": "",
+  "status": "completed",
+  "dev_type": null,
+  "scope": null,
+  "package": null,
+  "priority": "P2",
+  "creator": "pixelcola",
+  "assignee": "pixelcola",
+  "createdAt": "2026-05-12",
+  "completedAt": "2026-05-12",
+  "branch": null,
+  "base_branch": "main",
+  "worktree_path": null,
+  "commit": null,
+  "pr_url": null,
+  "subtasks": [],
+  "children": [],
+  "parent": null,
+  "relatedFiles": [],
+  "notes": "",
+  "meta": {}
+}
diff --git a/.trellis/workspace/pixelcola/index.md b/.trellis/workspace/pixelcola/index.md
@@ -8,7 +8,7 @@
 
 <!-- @@@auto:current-status -->
 - **Active File**: `journal-1.md`
-- **Total Sessions**: 6
+- **Total Sessions**: 7
 - **Last Active**: 2026-05-12
 <!-- @@@/auto:current-status -->
 
@@ -19,7 +19,7 @@
 <!-- @@@auto:active-documents -->
 | File | Lines | Status |
 |------|-------|--------|
-| `journal-1.md` | ~205 | Active |
+| `journal-1.md` | ~238 | Active |
 <!-- @@@/auto:active-documents -->
 
 ---
@@ -29,6 +29,7 @@
 <!-- @@@auto:session-history -->
 | # | Date | Title | Commits | Branch |
 |---|------|-------|---------|--------|
+| 7 | 2026-05-12 | Expand test coverage | `764205a` | `test/improve-coverage` |
 | 6 | 2026-05-12 | Update README installation instructions | `49680f6` | `docs/readme-install-uv-tool` |
 | 5 | 2026-05-12 | Fix restart active profile | `010e59e` | `fix/restart-active-config` |
 | 4 | 2026-05-12 | Fix Windows subprocess output decoding | `e90a676` | `fix/windows-subprocess-output-decoding` |

diff --git a/.trellis/workspace/pixelcola/journal-1.md b/.trellis/workspace/pixelcola/journal-1.md
@@ -203,3 +203,36 @@ Documented Scoop runtime dependency installation and uv tool install, upgrade, a
 ### Next Steps
 
 - None - task complete
+
+
+## Session 7: Expand test coverage
+
+**Date**: 2026-05-12
+**Task**: Expand test coverage
+**Branch**: `test/improve-coverage`
+
+### Summary
+
+Added CLI, profile, state, and service tests covering command success paths, failure propagation, and state preservation.
+
+### Main Changes
+
+(Add details)
+
+### Git Commits
+
+| Hash | Message |
+|------|---------|
+| `764205a` | (see git log) |
+
+### Testing
+
+- [OK] (Add test results)
+
+### Status
+
+[OK] **Completed**
+
+### Next Steps
+
+- None - task complete
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		{"_example": "Fill with {\"file\": \"<path>\", \"reason\": \"<why>\"}. Put spec/research files only — no code paths. Run `python3 .trellis/scripts/get_context.py --mode packages` to list available specs. Delete this line once real entries are added."}