fix: properly remove yoga node from parent on layout destroy #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

Riphal wants to merge 9 commits into pixijs:main from aquila-lab:fix/layout-destroy-remove-from-parent

src/core/Layout.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -297,6 +297,7 @@ export class Layout { @@
             this.destroyed = true;
             this.invalidateRoot();
+            onChildRemoved(this);
             this.yoga.free();
             this.target.off('added', this._onChildAdded, this);
             this.target.off('removed', this._onChildRemoved, this);
@@ Expand Down @@