Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@ name: PR Automation
on:
pull_request:
branches: [ '**' ]
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
jobs:
build:
runs-on: macos-latest
timeout-minutes: 30
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -30,12 +34,30 @@ jobs:
run: npm ci --ignore-scripts --no-audit --no-fund

# `npm rebuild` will run all those post-install scripts for us.
# Skip the electron (242MB) and chromium (~170MB) binary downloads: tests only
# use webkit, installed below. Without timeouts a stalled download hangs the
# job silently for hours.
- name: Rebuild
shell: bash
run: npm rebuild
run: npm rebuild --foreground-scripts
timeout-minutes: 15
env:
ELECTRON_SKIP_BINARY_DOWNLOAD: 1
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1

# Cache the browser binaries so the CDN download (which can stall on degraded
# runner networks) only happens when the playwright version changes.
- name: Cache Playwright Browsers
uses: actions/cache@v4
with:
path: ~/Library/Caches/ms-playwright
key: ${{ runner.os }}-playwright-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-playwright-

- name: Install Playwright Browsers
run: npx playwright install --with-deps
run: npx playwright install --with-deps webkit
timeout-minutes: 10

- name: Run Unit Tests
run: npm run test
Expand Down
2 changes: 1 addition & 1 deletion .stackblitz/react/src/boilerplate.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export default function App({ children, assets }) {
return {
alias: asset,
src: asset,
loadParser: 'loadTextures',
parser: 'texture',
};
}

Expand Down
6 changes: 6 additions & 0 deletions .storybook/styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,10 @@ body {
display: flex;
justify-content: center;
align-items: center;
}

/* An inline canvas reserves font descender space below it, pushing the centered
wrapper 2px above the viewport and leaving white body rows in screenshots. */
canvas {
display: block;
}
2 changes: 1 addition & 1 deletion docs/docs/examples/boilerplate.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export default function App({ children, assets }) {
return {
alias: asset,
src: asset,
loadParser: 'loadTextures',
parser: 'texture',
};
}

Expand Down
2 changes: 1 addition & 1 deletion docs/src/components/Playground/examples/boilerplate.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export default function App({ children, assets }) {
return {
alias: asset,
src: asset,
loadParser: 'loadTextures',
parser: 'texture',
};
}

Expand Down
Loading
Loading