feat: Add Application onDestroy prop#643
Open
zenblender wants to merge 2 commits into
Open
Conversation
commit: |
Collaborator
|
Looking good! I am guessing adding the onDestroy function to the application state was the cleanest way to route it to the proper place for being called? Are users going to expect that we take a ref to this function or do we need to track it in depenedencies? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
onDestroyprop on<Application>.Unmounting of roots is an asynchronous process, so I thought it would be a good idea to provide this mechanism so the consumer will be notified when the underlying Pixi.js application has indeed been destroyed. This can help in cases where specific or additional clean-up is needed once the Pixi.js application(s) are no longer running.