pj_pool_alloc_from_block: Eliminate unsafe cast#4927
Open
kunkku wants to merge 1 commit intopjsip:masterfrom
Open
pj_pool_alloc_from_block: Eliminate unsafe cast#4927kunkku wants to merge 1 commit intopjsip:masterfrom
kunkku wants to merge 1 commit intopjsip:masterfrom
Conversation
If the most significant bit of the size argument was set, casting to pj_ssize_t yielded a negative value, causing false positives in the size check. This resulted in returning a pointer to a buffer that has less capacity than requested. This fixes regressions in the following commits: * 9f3a3d4 * 43a652a * 214b609 The original check prior to these commits was correct, though a bit hard to read for both humans and compilers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the most significant bit of the
sizeargument was set, casting topj_ssize_tyielded a negative value, causing false positives in the size check. This resulted in returning a pointer to a buffer that has less capacity than requested.This fixes regressions caused by #4382, #4389 and #4391. The original check prior to these PRs was correct, though a bit hard to read for both humans and compilers.