Update banlists for all singles tiers#18
Merged
Conversation
Contributor
|
Thanks! I think you need to update the tiers.json testdata to get the tests to pass (possibly because it just encodes the deltas? i forgot exactly). i think theres an automated way to do this |
Contributor
|
hmm i think #3 (comment) is where it was generated but that doesnt look like a delta. im not entirely sure why changing these tiers effects this output? i feel by it encodes stuff not present in the PS tier data and maybe also needs to be added in some form to tiers.json as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the banlists to be the same as smogon/usage-stats#11.