pkp/immersion#126 Navigation landmark missing label#158
Open
israelcefrin wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Hi @kaitlinnewson , This PR fixes the missing label for navigation menus: #126 |
Member
|
Hi @israelcefrin, sorry for the delay on reviewing this! I think it looks fine, but wondered if it makes sense to use an |
Contributor
Author
|
My apologies for my delay, I will test the aria-labelledby to use the current H2 text labels. |
Contributor
Author
|
Hi @kaitlinnewson , I've switched it to arialabelledby and the code works and is much more simple. I've had to add IDs to each heading. |
| id="immersion_content_header"{if $immersionHomepageImage} style="background-image: url('{$publicFilesDir}/{$immersionHomepageImage.uploadName|escape:"url"}')"{/if}> | ||
| <div class="container-fluid"> | ||
| <nav class="main-header__admin{if $localeShow} locale-enabled{else} locale-disabled{/if}"> | ||
| <nav class="main-header__admin{if $localeShow} locale-enabled{else} locale-disabled{/if}" aria-labelledby="immersion_content_header_user_menu"> |
Member
There was a problem hiding this comment.
Since the h2 below is wrapped in {if !empty(trim($userMenu))}, should this also be to ensure it exists?
Member
|
Hi @israelcefrin, just one additional comment on this one - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
aria-labelfor the landmarknavcomponents on the top.Issue: #126