pkp/immersion#142 Menu item that shows a submenu is a link instead of a button #160
Open
israelcefrin wants to merge 2 commits into
Open
pkp/immersion#142 Menu item that shows a submenu is a link instead of a button #160israelcefrin wants to merge 2 commits into
israelcefrin wants to merge 2 commits into
Conversation
israelcefrin
moved this from In progress
to Ready for review/testing
in Accessibility (themes)
Contributor
Author
|
Hi @kaitlinnewson , This PR adjusts the submenu opener to be a button instead of a link element: #142 |
Contributor
Author
|
Hi @kaitlinnewson , |
| button.main-header__admin-link.dropdown-toggle, | ||
| .main-header button.main-header__nav-link, | ||
| .main-header button.main-header__admin-link { | ||
| border: none !important; |
Member
There was a problem hiding this comment.
Suggested change
| border: none !important; | |
| border: 0 none !important; |
... then you can remove the border-width line below. Also applies to line 181 and 192.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using native
buttonHTML element to prevent from clicking on link when opening the submenu.Issue: #142