Skip to content

Comments

Refactor validation and section selection in QuickSubmitForm#111

Open
evici wants to merge 1 commit intopkp:mainfrom
evici:development
Open

Refactor validation and section selection in QuickSubmitForm#111
evici wants to merge 1 commit intopkp:mainfrom
evici:development

Conversation

@evici
Copy link

@evici evici commented Nov 24, 2025

Refactor issue validation and section selection logic in QuickSubmitForm.php. Improved error handling and streamlined the process for selecting sections and managing user groups.

Refactor issue validation and section selection logic in QuickSubmitForm.php. Improved error handling and streamlined the process for selecting sections and managing user groups.
@asmecher
Copy link
Member

@evici, is there a particular problem that this solves, or is it just a rearrangement of the code?

@evici
Copy link
Author

evici commented Nov 25, 2025

@evici, is there a particular problem that this solves, or is it just a rearrangement of the code?

In multi-journal setup we do not have manager users as such it was required to have by plugin logic. In those situations we had err 500 and could not work with QuickSubmit.

This fix applies "sanity check" on usergroups in journals.

@asmecher
Copy link
Member

Thanks, that helps. I see the additional fallbacks on Role::ROLE_ID_SUB_EDITOR, followed by any role at all.

I agree that the Role::ROLE_ID_SUB_EDITOR fallback is a good idea, but I'm not sure about the last fallback; it could be something created by the Journal Manager that is completely unrelated to their work with QuickSubmit.

Could you adjust this PR so that it only includes the change that adds the Role::ROLE_ID_SUB_EDITOR fallback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants