pkp/pkp-lib#12337 CSS masking to handle auto complete off for password type input - #879
pkp/pkp-lib#12337 CSS masking to handle auto complete off for password type input#879touhidurabir wants to merge 1 commit into
Conversation
| * this returns false and the field falls back to type="password" | ||
| * with autocomplete="new-password" + vendor data-* attrs. | ||
| */ | ||
| isMaskedSecret() { |
There was a problem hiding this comment.
Hi @touhidurabir , seems that the different browsers and extensions are being quite inconsistent on this.
I will try to push back here (sorry), to see whether we could go with simpler version, as this is quite convoluted.
Could not we for compliance purposes just go with autocomplete=off and if the extensions browsers fails to follow that - I don't think thats our problem, but they are not following attribute which is meant to achieve this behaviour.
@asmecher Any thoughts on how far we need to take this?
There was a problem hiding this comment.
this is quite convoluted.
I agree on this 100% .
Could not we for compliance purposes just go with autocomplete=off and if the extensions browsers fails to follow that - I don't think thats our problem, but they are not following attribute which is meant to achieve this behaviour.
If we can do that, that's best for us . However European Commission Web Application Security Standard set this as a requirement . And seems some browser and extension just simply does not respect the attr autocomplete=off, specially when considering FireFox only as browser . So I make an update PR on this to handle such cases .
2 participants
for pkp/pkp-lib#12337 .