Improve form validation accessibility - #934
Open
web3blind wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-invalidfrom valid form controls and only rendersaria-invalid="true"when the field has validation errors.aria-describedbywhen errors are present, so the invalid field is programmatically associated with its error text.Related issues
Addresses the Vue form stack used by the OJS submission workflow:
Verification
npm test -- --run— 6 files / 58 tests passed.npx eslint src/components/Form/FormErrors.vue src/components/Form/FormPage.vue src/components/Form/fields/FieldBase.vue src/components/Form/fields/FieldText.vue src/components/Form/fields/FieldTextarea.vue src/components/Form/fields/FieldSelect.vue src/components/Form/fields/FieldDate.vue src/components/Form/fields/FieldOptions.vue src/components/Form/fields/FieldRadioInput.vue src/components/Form/fields/FieldMetadataSetting.vue src/components/Form/fields/FieldPubId.vue src/components/Form/fields/FieldArchivingPn.vue— 0 errors; existing warnings only.git diff --check— passed.Note:
npm run lintcurrently exits before linting because the upstream script passes--ignore-pathwhile this checkout useseslint.config.js; the targeted ESLint command above avoids that script-level blocker.