Skip to content

pkp/pkp-lib#13039 Bug, galleys should be editable by author in OPS if he got the permission - #948

Open
jardakotesovec wants to merge 2 commits into
pkp:stable-3_5_0from
jardakotesovec:i13039_3_5
Open

pkp/pkp-lib#13039 Bug, galleys should be editable by author in OPS if he got the permission#948
jardakotesovec wants to merge 2 commits into
pkp:stable-3_5_0from
jardakotesovec:i13039_3_5

Conversation

@jardakotesovec

Copy link
Copy Markdown
Contributor

For pkp/pkp-lib#13039. Cherry-picked from the main PR #947 (see its description for details); the only adaptation is that stable-3_5_0 has no 'More information' galley action, so those references are absent here.

  • Passes canCurrentUserEditPublication to the GalleyManager.
  • In OPS, authors can add/edit/change file/delete/order galleys when they have the permission to edit the publication, mirroring the backend (PreprintGalleyGridHandler). OJS/OMP authors are unaffected.
  • Introduces a read-only GALLEY_VIEW action offered to OPS authors whenever the galleys are not editable, consistent with 3.3/3.4.
  • Drops the 'View' relabeling of the Edit action for published publications (obsolete since Relax editing metadata on published/posted materials pkp-lib#10263).

… he got the permission

- Pass canCurrentUserEditPublication to the GalleyManager
- In OPS, authors can add/edit/change file/delete/order galleys when they
  have the permission to edit the publication, mirroring
  PreprintGalleyGridHandler on the backend
- Introduce a read-only GALLEY_VIEW action, offered to OPS authors
  whenever the galleys are not editable, consistent with 3.3/3.4
- Drop the 'View' relabeling of the Edit action for published
  publications - obsolete since editorial roles can edit galleys of
  published publications (pkp/pkp-lib#10263)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants