fix and check all suppressed errors#138
Draft
maxenglander wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Max Englander <max@planetscale.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the suppression of errors by replacing blank identifier patterns with proper error checking in the code.
- Replaces error suppression with explicit error handling in the TableCursorToSerializedCursor function.
- Implements error handling for checkConnectionStatus to log connection errors.
- Updates .golangci.yml to enable errcheck with check-blank set to true.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/internal/planetscale_connection.go | Adds error handling for converting TableCursor to a serialized cursor. |
| cmd/airbyte-source/check.go | Implements error handling for checking the connection status. |
| .golangci.yml | Updates linting configuration to check for blank error assignments. |
|
|
||
| cs, _ := checkConnectionStatus(ch.Database, psc) | ||
| cs, err := checkConnectionStatus(ch.Database, psc) | ||
| if err != nil { |
There was a problem hiding this comment.
After logging the error in the 'if' block, consider altering the control flow to avoid using 'cs' when an error occurs. For example, returning from the function or using an alternative handling mechanism would prevent potential issues from processing an invalid connection status.
Collaborator
Author
There was a problem hiding this comment.
I tried doing that originally, but it broke tests. Let's add a // TODO here to fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prev: #137
Fix all cases of
..., _ := errorReturningThing().